WWSTCERT-10247 Add pad19 dimmer driver by JerryYang01 · Pull Request #2762 · SmartThingsCommunity/SmartThingsEdgeDrivers

JerryYang01 · 2026-02-06T06:42:44Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

A profile of PAD19 (dimmer switch).

The edge driver of PAD19 for WWST certification.

CLAassistant · 2026-02-06T06:42:51Z

All committers have signed the CLA.

greens

You should just be adding a sub-driver to the base driver, not adding a new driver in a folder under the base driver.

Here's an example from another partner of how this looks: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/2371/changes

JerryYang01 · 2026-02-11T08:38:07Z

Dear SmartThings Team, Thank you for your review comments and guidance regarding our pull request. We would like to seek clarification on the driver structure requirement. Based on the feedback, it appears that we are expected to add our implementation as a sub-driver under the existing base driver rather than creating a separate driver. Our original intention was to develop and maintain a dedicated Philio Edge Driver under our company name. Could you please confirm whether, for WWST certification submissions within the SmartThingsCommunity repository, all device support must be integrated into the existing base drivers as sub-drivers? If maintaining a standalone Philio driver is not supported within this repository, we would appreciate your advice on the recommended approach for vendors who wish to publish and manage their own branded drivers while still pursuing WWST certification. Thank you for your clarification and support. Best regards, Jerry Yang Steven Green 於 2026/2/11 上午 07:30 寫道:

***@***.**** requested changes on this pull request. You should just be adding a sub-driver to the base driver, not adding a new driver in a folder under the base driver. Here's an example from another partner of how this looks: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/2371/changes — Reply to this email directly, view it on GitHub <#2762 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJSU2RL3K7R3XKEEN5SPUQ34LJSY7AVCNFSM6AAAAACUGCC4JSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTOOBSGE2DSNZVG4>. You are receiving this because you modified the open/close state.Message ID: ***@***.***>

-- 楊嘉慶軟體設計部經理 leaf 新北市新莊區中正路651之1號7樓 Tel: +886-2-2908-8952 ext:304 Fax: +886-2-2908-8652 http://philio-tech.com leaf

greens · 2026-02-11T23:39:10Z

@JerryYang01 based on the code you've included in this PR, it's not clear that you would gain anything by having a separate driver. Your device seems to behave according to the Z-Wave spec, and would be well covered by our base z-wave switch driver. Our base drivers are written so that most devices can integrate with just the addition of the device's fingerprint to the fingerprints.yml file. This is for our own east of maintainability, but also to make it easy for partners such as yourselves.

But also, if your intent was to have an all new driver, you would want it to be alongside zwave-switch in the directory structure, not under it.

JerryYang01 · 2026-02-12T02:21:39Z

Hi Steven : Thank you for the detailed explanation and guidance. I understand your point regarding the use of the base Z-Wave switch driver and the benefits it provides in terms of maintainability and integration. I’ll review the implementation and try modifying it by adding the device fingerprint to the existing base driver instead of creating a separate one. If I run into any issues or have further questions, I’ll follow up. Thanks again for the clarification. Best regards, Jerry Yang Steven Green 於 2026/2/12 上午 07:39 寫道:

@JerryYang01 <https://github.com/JerryYang01> based on the code you've included in this PR, it's not clear that you would gain anything by having a separate driver. Your device seems to behave according to the Z-Wave spec, and would be well covered by our base z-wave switch driver. Our base drivers are written so that most devices can integrate with just the addition of the device's fingerprint to the |fingerprints.yml| file. This is for our own east of maintainability, but also to make it easy for partners such as yourselves. But also, if your intent was to have an all new driver, you would want it to be /alongside/ |zwave-switch| in the directory structure, not under it.

-- 楊嘉慶軟體設計部經理 leaf 新北市新莊區中正路651之1號7樓 Tel: +886-2-2908-8952 ext:304 Fax: +886-2-2908-8652 http://philio-tech.com leaf

wkhenon · 2026-02-12T19:14:38Z

drivers/SmartThings/zwave-switch/src/philio-dimmer-switch/init.lua

+1 to Steven's feedback regarding the driver structure. Also be sure to remove the print() statements from this file.

greens · 2026-02-25T19:28:39Z

drivers/SmartThings/zwave-switch/src/preferences.lua

+    PARAMETERS = {
+    parameter1 = {parameter_number = 1, size = 1},
+    parameter2 = {parameter_number = 2, size = 1},
+    parameter3 = {parameter_number = 3, size = 1},
+    parameter4 = {parameter_number = 4, size = 1},
+    parameter5 = {parameter_number = 5, size = 1},
+    parameter6 = {parameter_number = 6, size = 1}
+    }


these are intended to match up to preferences on the device profile, but your profile has none

greens · 2026-02-25T19:29:43Z

drivers/SmartThings/zwave-switch/profiles/philio-dimmer-switch.yml

this is a duplicate of the existing switch-level

greens · 2026-02-25T19:30:21Z

drivers/SmartThings/zwave-switch/fingerprints.yml

+  - id: Philio/PAD19
+    deviceLabel: PAD19
+    manufacturerId: 0x013C
+    productType: 0x0005
+    productId: 0x008A
+    deviceProfileName: philio-dimmer-switch


again, I think this fingerprint is the only change you actually need to include.

greens · 2026-02-27T21:08:04Z

drivers/SmartThings/zwave-switch/src/philio-dimmer-switch/init.lua

all .lua files need to include our copyright and license statement

greens · 2026-02-27T21:08:08Z

drivers/SmartThings/zwave-switch/src/philio-dimmer-switch/init.lua

+local SwitchMultilevel = (require "st.zwave.CommandClass.SwitchMultilevel")({ version = 4 })
+
+
+-- print("DEBUG: philio-dimmer-switch/init.lua loaded")


greens · 2026-02-27T21:10:55Z

drivers/SmartThings/zwave-switch/src/philio-dimmer-switch/init.lua

+---- Refresh 指令函式（SmartThings Test Suite 必要）
+local function refresh_cmd(driver, device, command)
+  -- print("DEBUG: PAD19 refresh_cmd called")
+
+  -- 取得目前開關狀態
+  local switch_get = Basic:Get({})
+  device:send(switch_get)
+
+  -- 取得目前dimmer的level
+  local switchlevel_get = SwitchMultilevel:Get({})
+  device:send(switchlevel_get)
+end


equivalent to the defaults

greens · 2026-02-27T21:11:01Z

drivers/SmartThings/zwave-switch/src/philio-dimmer-switch/init.lua

+local function device_init(driver, device)
+  -- print("DEBUG: PAD19 device_init called")
+end


greens · 2026-02-27T21:11:51Z

drivers/SmartThings/zwave-switch/src/philio-dimmer-switch/init.lua

+local function device_added(driver, device)
+  -- print("DEBUG: PAD19 device_added - init state off")
+  device:emit_event(capabilities.switch.switch.off())
+  device:emit_event(capabilities.switchLevel.level(0))
+  -- print("DEBUG: PAD19 Initial switchlevel = 0")
+end


the default base driver will read these values from the device on add, are you seeing some unacceptable delay here?

greens · 2026-02-27T21:11:55Z

drivers/SmartThings/zwave-switch/src/philio-dimmer-switch/init.lua

+-- NEW: 修正 driverSwitched 崩潰
+local function device_driver_switched(driver, device, event, args)
+  -- print("DEBUG: PAD19 driverSwitched - ignored")
+end


greens · 2026-02-27T21:12:07Z

drivers/SmartThings/zwave-switch/src/philio-dimmer-switch/init.lua

+  -- 設置 Z-Wave 設備配置
+  zwave_config = {}
+--  zwave_config = {},
+
+  -- 指定can_handle腳本, 讓上層可以先檢查這台Device是否能用這個子驅動控制,可以才載入
+--  can_handle = require("philio-dimmer-switch.can_handle")


greens

PR needs to be rebased

greens

add unit tests if you believe your device has unique behavior. see the tests directory for examples

This reverts commit 9a71417.

Add comments about aeotec doorbell siren bugs

The server will return `INVALID_IN_STATE` if `RemoveZone` is issued while there is an existing trigger for the given zone. The trigger should be removed first before attempting to remove the zone.

…ymbol - Fixed issue where grep would read files as binaries and fail to parse them, so forcing reading of them as a text file - Added copyright logo to regex for better coverage of copyright notice detection

…RT-10451), ZSE44 (WWSTCERT-10455) (SmartThingsCommunity#2794) * fingerprints for Zooz sensors: ZSE11, ZSE41, ZSE44 * removes redundant white space * cleanup * decimal -> hex

…mmunity#2820) audioRecording should only be included in the camera profile if the AUDIO feature of CAVSM is available and if the device supports the PushAvStreamTransport cluster (previously only the former was being checked).

update fingerprints pointing to specific ranges

…martThingsCommunity#2776) * initial commit * handle co value * complete driver with tests * removed unused variable * changes according to pr comments * pr comments changes

…d them (SmartThingsCommunity#2792)

…Community/new_device/WWSTCERT-10528" This reverts commit 4351e1b, reversing changes made to a94358e.

- Updated copyright on missing files and fixed missing newlines at EOF

…g01/SmartThingsEdgeDrivers into add-pad19-dimmer-driver

JerryYang01 added 2 commits February 6, 2026 14:04

Add files via upload

08e8d73

A profile of PAD19 (dimmer switch).

Add files via upload

bd176ce

The edge driver of PAD19 for WWST certification.

JerryYang01 closed this Feb 6, 2026

JerryYang01 reopened this Feb 6, 2026

greens changed the title ~~Add pad19 dimmer driver~~ WWSTCERT-10247 Add pad19 dimmer driver Feb 10, 2026

greens requested review from greens, pegor-karoglanian and wkhenon February 10, 2026 23:27

greens suggested changes Feb 10, 2026

View reviewed changes

wkhenon reviewed Feb 12, 2026

View reviewed changes

JerryYang01 added 2 commits February 25, 2026 14:03

add Philio PAD19 into zwave-switch

b3390ef

I remark the print command

e0f1f7e

greens reviewed Feb 25, 2026

View reviewed changes

The range of my switchLevel is between 0~99

efb35d9

greens reviewed Feb 27, 2026

View reviewed changes

I add a test file "test_philio_pad19.lua"

17e8af5

greens and others added 30 commits April 2, 2026 09:31

WWSTCERT-10417 ubisys dimmer D1-R

8448500

CHAD-17079: zigbee-valve lazy load sub-drivers

7005d1c

CHAD-17089: zwave-lock lazy loading of subdrivers

5683653

CHAD-17094: zwave-smoke-alarm lazy loading of sub-drivers

6aebee5

add initialPress handling for BILRESA scrolling

bc44349

CHAD-17083: zigbee-window-treatment lazy loading of sub-drivers

7994f93

Revert "CHAD-17092: zwave-sensor lazy loading of sub-drivers"

e4b6d01

This reverts commit 9a71417.

WWSTCERT-10426 Halo Select Plus

00a2974

Increase Z-Wave driver coverage

9e59f5f

Add comments about aeotec doorbell siren bugs

WWSTCERT-10480 GELUBU Door Lock G30

a6b9230

I rebase today.

eea95fb

I remark the print command

3045a58

revert the recent profile components check additions

c3a74ba

The range of my switchLevel is between 0~99

83dcf05

Improve Zigbee driver test coverage

bc01218

Change the icon for the Matter Ikea knob and dual button

d7009a1

Matter Camera: Remove trigger before zone (SmartThingsCommunity#2816)

b180f06

The server will return `INVALID_IN_STATE` if `RemoveZone` is issued while there is an existing trigger for the given zone. The trigger should be removed first before attempting to remove the zone.

Fixed pre-commit script misread binaries and allowing for copyright s…

2a79f05

…ymbol - Fixed issue where grep would read files as binaries and fail to parse them, so forcing reading of them as a text file - Added copyright logo to regex for better coverage of copyright notice detection

fingerprints for Zooz sensors: ZSE11 (WWSTCERT-10463) , ZSE41 (WWSTCE…

ba060b9

…RT-10451), ZSE44 (WWSTCERT-10455) (SmartThingsCommunity#2794) * fingerprints for Zooz sensors: ZSE11, ZSE41, ZSE44 * removes redundant white space * cleanup * decimal -> hex

CHAD-12653 Zigbee: Add support for reading ColorTemperatureRange

65e17fe

update fingerprints pointing to specific ranges

WWSTCERT-10528 HAOJAI Smart Switch

e812eab

WWSTCERT-10511/WWSTCERT-10514 Add support to frient smoke co sensor (S…

a18c412

…martThingsCommunity#2776) * initial commit * handle co value * complete driver with tests * removed unused variable * changes according to pr comments * pr comments changes

Matter Switch: Subscribe to power topology attributes rather than rea…

81da0c0

…d them (SmartThingsCommunity#2792)

Revert "Merge pull request SmartThingsCommunity#2823 from SmartThings…

7f16d3e

…Community/new_device/WWSTCERT-10528" This reverts commit 4351e1b, reversing changes made to a94358e.

CHAD-17683: Tagging passing tests with min_api_version=19

d02f477

- Updated copyright on missing files and fixed missing newlines at EOF

I add a test file "test_philio_pad19.lua"

3992fbb

I removed profile and changed to switch-level

703e269

I modified fingerprints.yml

2fc257c

Merge branch 'add-pad19-dimmer-driver' of https://github.com/JerryYan…

bee5289

…g01/SmartThingsEdgeDrivers into add-pad19-dimmer-driver

		local SwitchMultilevel = (require "st.zwave.CommandClass.SwitchMultilevel")({ version = 4 })


		-- print("DEBUG: philio-dimmer-switch/init.lua loaded")

Conversation

JerryYang01 commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

CLAassistant commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greens left a comment

Choose a reason for hiding this comment

Uh oh!

JerryYang01 commented Feb 11, 2026 via email

Uh oh!

greens commented Feb 11, 2026

Uh oh!

JerryYang01 commented Feb 12, 2026 via email

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greens left a comment

Choose a reason for hiding this comment

Uh oh!

greens left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

JerryYang01 commented Feb 6, 2026 •

edited

Loading

CLAassistant commented Feb 6, 2026 •

edited

Loading